Merge pull request #86 from GIScience/fix/timeout-not-passed-correctly

fix: timeout not passed to default arguments
GIScience · Jul 31, 2024 · 6f15b96 · 6f15b96
2 parents c5b0097 + 60ce10d
commit 6f15b96
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/OrsBase.js b/src/OrsBase.js
@@ -25,14 +25,16 @@ class OrsBase {
     if (args[Constants.propNames.service]) {
       this.defaultArgs[Constants.propNames.service] = args[Constants.propNames.service]
     }
+    if (args[Constants.propNames.timeout]) {
+      this.defaultArgs[Constants.propNames.timeout] = args[Constants.propNames.timeout]
+    }
     if (Constants.propNames.apiKey in args) {
       this.defaultArgs[Constants.propNames.apiKey] = args[Constants.propNames.apiKey]
     } else if (!args[Constants.propNames.host]) {
       // Do not error if a host is specified; useful for locally-run instances of ORS
       console.error(Constants.missingAPIKeyMsg)
       throw new Error(Constants.missingAPIKeyMsg)
     }
-
   }
 
   checkHeaders() {
@@ -65,7 +67,7 @@ class OrsBase {
 
   async createRequest(body) {
     const controller = new AbortController()
-    const timeout = setTimeout(() => controller.abort('timed out'), this.defaultArgs[Constants.propNames.timeout] || 5000)
+    const timeout = setTimeout(() => controller.abort(), this.defaultArgs[Constants.propNames.timeout] || 5000)
 
     try {
       const orsResponse = await this.fetchRequest(body, controller)

diff --git a/src/OrsGeocode.js b/src/OrsGeocode.js
@@ -129,7 +129,7 @@ class OrsGeocode extends OrsBase {
 
   async geocodePromise() {
     const controller = new AbortController()
-    const timeout = setTimeout(() => controller.abort('timed out'), this.defaultArgs[Constants.propNames.timeout] || 5000)
+    const timeout = setTimeout(() => controller.abort(), this.defaultArgs[Constants.propNames.timeout] || 5000)
 
     try {
       const orsResponse = await this.fetchGetRequest(controller)