Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/leaflet dev app #83

Merged
merged 11 commits into from
Jul 11, 2024
Merged

Feature/leaflet dev app #83

merged 11 commits into from
Jul 11, 2024

Conversation

TheGreatRefrigerator
Copy link
Collaborator

No description provided.

@TheGreatRefrigerator TheGreatRefrigerator force-pushed the feature/leaflet-dev-app branch 3 times, most recently from 59e940e to 245198e Compare July 11, 2024 11:17
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 88.54167% with 22 lines in your changes missing coverage. Please review.

Project coverage is 95.32%. Comparing base (7b3a190) to head (eb907d5).
Report is 16 commits behind head on main.

Files Patch % Lines
dev_app/components/IsochronesApp.js 71.42% 10 Missing ⚠️
dev_app/components/DirectionsApp.js 85.71% 4 Missing ⚠️
dev_app/components/ElevationApp.js 91.30% 2 Missing ⚠️
dev_app/components/MatrixApp.js 91.30% 2 Missing ⚠️
dev_app/components/OptimizationApp.js 93.33% 2 Missing ⚠️
dev_app/components/PoisApp.js 92.59% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   99.08%   95.32%   -3.77%     
==========================================
  Files          15       21       +6     
  Lines         328      513     +185     
  Branches       55       62       +7     
==========================================
+ Hits          325      489     +164     
- Misses          3       24      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blackbirdem and others added 10 commits July 11, 2024 14:04
uses Vue dynamic components and async imports from Leaflet to provide SSR

- split App into sidebar and map
- add blue, red and green icon
- add icon options and route colour options
- add different colors for multiple isochrones and their points
- Adjust tests to reflect changes
- change HelloWorld into GeocodeApp

- fix eslint issues:
  - vue/multi-word-component-names
  - no-prototype-builtins
Co-authored-by: Amandus Butzer <amandus.butzer@heigit.org>
adjust .babelrc for babel-plugin-istanbul
as eslint has built in module resolution with the new flat config,
@rushstack/eslint-patch is not needed anymore.
Instead @eslint/eslintrc, @eslint/js & globals packages are needed now.

note: @eslint/migrate-config was used to migrate .eslintrc.cjs to eslint.config.mjs
by running 'npm run lint'
Copy link

sonarcloud bot commented Jul 11, 2024

@TheGreatRefrigerator TheGreatRefrigerator merged commit 8716666 into main Jul 11, 2024
3 checks passed
@TheGreatRefrigerator TheGreatRefrigerator deleted the feature/leaflet-dev-app branch July 11, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants