-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(swagger): Springfox to openapi migration #1380
Merged
MichaelsJP
merged 1 commit into
master
from
1027-migrate-from-springfox-swagger-to-springdoc-openapi
Jun 20, 2023
Merged
feat(swagger): Springfox to openapi migration #1380
MichaelsJP
merged 1 commit into
master
from
1027-migrate-from-springfox-swagger-to-springdoc-openapi
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelsJP
force-pushed
the
1027-migrate-from-springfox-swagger-to-springdoc-openapi
branch
from
March 31, 2023 16:54
0839c7b
to
e12388c
Compare
MichaelsJP
force-pushed
the
1027-migrate-from-springfox-swagger-to-springdoc-openapi
branch
2 times, most recently
from
April 3, 2023 11:37
4d72651
to
e713c0d
Compare
openrouteservice/src/main/java/org/heigit/ors/api/OpenApiConfiguration.java
Outdated
Show resolved
Hide resolved
MichaelsJP
commented
Apr 13, 2023
openrouteservice/src/main/java/org/heigit/ors/api/OpenApiConfiguration.java
Outdated
Show resolved
Hide resolved
MichaelsJP
force-pushed
the
1027-migrate-from-springfox-swagger-to-springdoc-openapi
branch
from
April 17, 2023 14:36
a5ba5ae
to
2c602c6
Compare
TheGreatRefrigerator
force-pushed
the
1027-migrate-from-springfox-swagger-to-springdoc-openapi
branch
from
April 17, 2023 14:56
596a0b6
to
486d852
Compare
MichaelsJP
force-pushed
the
1027-migrate-from-springfox-swagger-to-springdoc-openapi
branch
4 times, most recently
from
April 26, 2023 12:12
9efae30
to
031b889
Compare
MichaelsJP
force-pushed
the
1027-migrate-from-springfox-swagger-to-springdoc-openapi
branch
from
May 5, 2023 12:31
031b889
to
345f2b3
Compare
MichaelsJP
force-pushed
the
1027-migrate-from-springfox-swagger-to-springdoc-openapi
branch
from
May 22, 2023 16:09
345f2b3
to
556258a
Compare
MichaelsJP
changed the title
Springfox to openapi migration
feat:Springfox to openapi migration
May 22, 2023
MichaelsJP
changed the title
feat:Springfox to openapi migration
feat(openapi): Springfox to openapi migration
May 22, 2023
MichaelsJP
changed the title
feat(openapi): Springfox to openapi migration
feat(swagger): Springfox to openapi migration
May 22, 2023
MichaelsJP
force-pushed
the
1027-migrate-from-springfox-swagger-to-springdoc-openapi
branch
4 times, most recently
from
May 25, 2023 08:52
c049c1c
to
0c0dc57
Compare
@jarinox Yes and no. We'll have public transit soon in our live API and the code supports it already. A curl request looks like this
Makes sense with the parameter, right? |
MichaelsJP
force-pushed
the
1027-migrate-from-springfox-swagger-to-springdoc-openapi
branch
4 times, most recently
from
June 19, 2023 11:24
58b4b90
to
9908662
Compare
This removes the outdated springfox library that was serving the swagger <3 version. openapi introduces swagger with version >=3 using the new openapi standard. The package is maintained and compatible with newer spring-boot versions. Co-authored-by: Amandus Butzer <amandus.butzer@heigit.org>
MichaelsJP
force-pushed
the
1027-migrate-from-springfox-swagger-to-springdoc-openapi
branch
from
June 19, 2023 16:20
9850763
to
b765ce9
Compare
takb
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally! lgtm.
MichaelsJP
deleted the
1027-migrate-from-springfox-swagger-to-springdoc-openapi
branch
June 20, 2023 08:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Close #1027
Information about the changes
Required changes to ors config (if applicable)
swagger_documentation_add_autogenerated_url
to let the user decide if the auto-generated (localhost) url should be added to the available servers. This is needed since the openapi package defines the servers as an array of possible endpoints, rather than a fixed string for one url only.