Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mapmatching candidate snaps #1457

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

takb
Copy link
Contributor

@takb takb commented May 30, 2023

Pull Request Checklist

  • 1. I have [rebased][rebase] the latest version of the master branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the [ors config documentation][config]
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground [renders correctly][api].

Information about the changes

  • Key functionality added:
    Use ORS-GH v4.7 and make use of the findCandidateSnaps() method to fix the HiddenMarkovMapMatcher.

@github-actions github-actions bot added the fix label May 30, 2023
@takb takb force-pushed the fix/mapmaching_candidate_snaps branch from e7317e5 to cc364c7 Compare May 30, 2023 11:35
@takb takb marked this pull request as ready for review May 30, 2023 11:45
@takb takb requested a review from aoles May 30, 2023 11:45
@github-actions github-actions bot added fix and removed fix labels May 30, 2023
@takb takb requested a review from MichaelsJP May 30, 2023 11:46
@github-actions github-actions bot added fix and removed fix labels May 30, 2023
@MichaelsJP MichaelsJP merged commit ad50a73 into master May 30, 2023
@MichaelsJP MichaelsJP deleted the fix/mapmaching_candidate_snaps branch May 30, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants