Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log rotation with CronTriggeringPolicy, set by ENV #1594

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix: log rotation with CronTriggeringPolicy, set by ENV #1594

merged 1 commit into from
Nov 3, 2023

Conversation

takb
Copy link
Contributor

@takb takb commented Nov 3, 2023

  • changed logging policy to CronTriggeringPolicy, defaulting to 00:00:00 h every day
  • introduced ENV variable ORS_LOG_PATTERN that sets this policy
  • added default of said ENV variable to openrouteservice-jws5-permanent-state file
  • added documentation to docs/installation/Installation-and-Usage.md

@takb takb requested a review from jhaeu November 3, 2023 10:34
@github-actions github-actions bot added fix and removed fix labels Nov 3, 2023
@github-actions github-actions bot added the fix label Nov 3, 2023
@takb takb marked this pull request as ready for review November 3, 2023 10:35
@github-actions github-actions bot added fix and removed fix labels Nov 3, 2023
@takb takb enabled auto-merge November 3, 2023 10:53
jhaeu
jhaeu approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@jhaeu jhaeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takb takb merged commit f6d8c70 into releases/v7.2.x Nov 3, 2023
16 checks passed
@takb takb deleted the fix/log-settings-cron branch November 3, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhaeu jhaeu jhaeu approved these changes

Assignees
No one assigned
Labels
fix
Projects
ors general
Status: Awaiting release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takb @jhaeu