Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logging): Repair the logging backend #1695

Merged
merged 4 commits into from
Feb 19, 2024
Merged

fix(logging): Repair the logging backend #1695

merged 4 commits into from
Feb 19, 2024

Commits on Feb 19, 2024

  1. fix(logging): Repair the logging backend 

    This removes the exclusion of log4j-slf4j2-impl (therefore including it) and removes the package slf4j-reload4j.

Graphhopper uses slf4j as a logging backend, whereas ors uses log4j.
We need log4j-slf4j2-impl to tunnel slf4j through our log4j logging interface. This is not 100% evident in all run scenarios. While native spring runs can cope with this partially, running in an external tomcat environment leads to no or missing log output once the war is deployed.

We don't need slf4j-reload4j right now, as it would only be useful for hot-reloading logging configs while ors is running. Another side effect of just keeping the lib is that when spring or tomcat is looking for a log facility, it sees log4j as well as slf4j-reload4j. It can happen, that it appends to slf4j-reload4j instead of log4j in certain scenarios, which leads to no available logging output. This confusion can lead to no log output in tomcat/war deployment scenarios.
    @MichaelsJP
    MichaelsJP committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    158ed75 View commit details
    Browse the repository at this point in the history

  2. fix(maven): Add spring-boot-starter-validation as it was missing 

    spring-boot-starter-validation is needed for object validation. When using beans, those features are automatically used and without this dependency no validation can happen and it dies silently. The warning message regarding the missing spring-boot-starter-validation package can only be seen in root: DEBUG mode.
    @MichaelsJP
    MichaelsJP committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    9e29a1e View commit details
    Browse the repository at this point in the history

  3. fix(maven): Remove unnecessary exclusion 

    org.jline.jline is already excluded in the main pom.
    @MichaelsJP
    MichaelsJP committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    7528db4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix/log4j-slf4j-logging-issues

    @takb
    takb committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f7ccbfd View commit details
    Browse the repository at this point in the history