#470: cleanup: introduce static imports, remove redundant throws-clauses

GIScience · Nov 4, 2022 · ecd0313 · ecd0313
1 parent 1943e2e
commit ecd0313
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 13 deletions.
diff --git a/...src/test/java/org/heigit/ohsome/oshdb/api/tests/MapReduceOSHDBIgniteAffinityCallTest.java b/...src/test/java/org/heigit/ohsome/oshdb/api/tests/MapReduceOSHDBIgniteAffinityCallTest.java
@@ -1,10 +1,10 @@
 package org.heigit.ohsome.oshdb.api.tests;
 
+import static org.heigit.ohsome.oshdb.api.db.OSHDBIgnite.ComputeMode.AFFINITY_CALL;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import java.util.Set;
 import java.util.stream.Collectors;
-import org.heigit.ohsome.oshdb.api.db.OSHDBIgnite;
 import org.heigit.ohsome.oshdb.util.time.OSHDBTimestamps;
 import org.junit.jupiter.api.Test;
 
@@ -20,7 +20,7 @@ class MapReduceOSHDBIgniteAffinityCallTest extends MapReduceOSHDBIgniteTest {
    * @throws Exception if something goes wrong
    */
   MapReduceOSHDBIgniteAffinityCallTest() throws Exception {
-    super(oshdb -> oshdb.computeMode(OSHDBIgnite.ComputeMode.AFFINITY_CALL));
+    super(oshdb -> oshdb.computeMode(AFFINITY_CALL));
   }
 
   @Test

diff --git a/...te/src/test/java/org/heigit/ohsome/oshdb/api/tests/MapReduceOSHDBIgniteLocalPeekTest.java b/...te/src/test/java/org/heigit/ohsome/oshdb/api/tests/MapReduceOSHDBIgniteLocalPeekTest.java
@@ -1,6 +1,6 @@
 package org.heigit.ohsome.oshdb.api.tests;
 
-import org.heigit.ohsome.oshdb.api.db.OSHDBIgnite;
+import static org.heigit.ohsome.oshdb.api.db.OSHDBIgnite.ComputeMode.LOCAL_PEEK;
 
 /**
  * {@inheritDoc}
@@ -14,6 +14,6 @@ class MapReduceOSHDBIgniteLocalPeekTest extends MapReduceOSHDBIgniteTest {
    * @throws Exception if something goes wrong
    */
   MapReduceOSHDBIgniteLocalPeekTest() throws Exception {
-    super(oshdb -> oshdb.computeMode(OSHDBIgnite.ComputeMode.LOCAL_PEEK));
+    super(oshdb -> oshdb.computeMode(LOCAL_PEEK));
   }
 }
diff --git a/...src/test/java/org/heigit/ohsome/oshdb/api/tests/MapReduceOSHDBIgniteMissingCacheTest.java b/...src/test/java/org/heigit/ohsome/oshdb/api/tests/MapReduceOSHDBIgniteMissingCacheTest.java
@@ -21,31 +21,31 @@ class MapReduceOSHDBIgniteMissingCacheTest extends MapReduceOSHDBIgniteTest {
 
   @Override
   @Test()
-  void testOSMContributionView() throws Exception {
+  void testOSMContributionView() {
     assertThrows(OSHDBTableNotFoundException.class, super::testOSMContributionView);
   }
 
   @Override
   @Test()
-  void testOSMEntitySnapshotView() throws Exception {
+  void testOSMEntitySnapshotView() {
     assertThrows(OSHDBTableNotFoundException.class, super::testOSMEntitySnapshotView);
   }
 
   @Override
   @Test()
-  void testOSMContributionViewStream() throws Exception {
+  void testOSMContributionViewStream() {
     assertThrows(OSHDBTableNotFoundException.class, super::testOSMContributionViewStream);
   }
 
   @Override
   @Test()
-  void testOSMEntitySnapshotViewStream() throws Exception {
+  void testOSMEntitySnapshotViewStream() {
     assertThrows(OSHDBTableNotFoundException.class, super::testOSMEntitySnapshotViewStream);
   }
 
   @Override
   @Test()
-  void testTimeoutMapReduce() throws Exception {
+  void testTimeoutMapReduce() {
     assertThrows(OSHDBTableNotFoundException.class, this::timeoutMapReduce);
   }
 

diff --git a/...te/src/test/java/org/heigit/ohsome/oshdb/api/tests/MapReduceOSHDBIgniteScanQueryTest.java b/...te/src/test/java/org/heigit/ohsome/oshdb/api/tests/MapReduceOSHDBIgniteScanQueryTest.java
@@ -1,8 +1,8 @@
 package org.heigit.ohsome.oshdb.api.tests;
 
+import static org.heigit.ohsome.oshdb.api.db.OSHDBIgnite.ComputeMode.SCAN_QUERY;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
-import org.heigit.ohsome.oshdb.api.db.OSHDBIgnite;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -17,12 +17,12 @@ class MapReduceOSHDBIgniteScanQueryTest extends MapReduceOSHDBIgniteTest {
    * @throws Exception if something goes wrong
    */
   MapReduceOSHDBIgniteScanQueryTest() throws Exception {
-    super(oshdb -> oshdb.computeMode(OSHDBIgnite.ComputeMode.SCAN_QUERY));
+    super(oshdb -> oshdb.computeMode(SCAN_QUERY));
   }
 
   @Override
   @Test
-  void testTimeoutStream() throws Exception {
+  void testTimeoutStream() {
     // ignore this test -> scanquery backend currently doesn't support timeouts for stream()
     assertTrue(true);
   }

diff --git a/...-api-ignite/src/test/java/org/heigit/ohsome/oshdb/api/tests/MapReduceOSHDBIgniteTest.java b/...-api-ignite/src/test/java/org/heigit/ohsome/oshdb/api/tests/MapReduceOSHDBIgniteTest.java
@@ -72,7 +72,7 @@ private static OSHDBDatabase initOshdb(Consumer<OSHDBIgnite> computeMode) {
       streamer.allowOverwrite(true);
 
       try (final ResultSet rst =
-          h2Stmt.executeQuery("select level, id, data from " + TableNames.T_NODES.toString())) {
+          h2Stmt.executeQuery("select level, id, data from " + TableNames.T_NODES)) {
         while (rst.next()) {
           final int level = rst.getInt(1);
           final long id = rst.getLong(2);