You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, when one supplies invalid datetime strings to the timestamps method of the map-reudcer (e.g. .timestamps("foo", "bar")), no exception is thrown immediately. Instead, this ends up in unspecified behaviour "down the road": the contribution view may throw null pointer exceptions, while the snapshot view simply ignores the invalid times and returns empty results.
Here's one part of the problem: unparseable timestamps are just ignored:
Describe the bug
Currently, when one supplies invalid datetime strings to the
timestamps
method of the map-reudcer (e.g..timestamps("foo", "bar")
), no exception is thrown immediately. Instead, this ends up in unspecified behaviour "down the road": the contribution view may throw null pointer exceptions, while the snapshot view simply ignores the invalid times and returns empty results.Here's one part of the problem: unparseable timestamps are just ignored:
oshdb/oshdb-util/src/main/java/org/heigit/bigspatialdata/oshdb/util/time/OSHDBTimestamps.java
Line 145 in 04abd72
To fix, the
.timestamps
method (and/or theOSHDBTimestamps
class) should check if the supplied timestamps are valid and parsable.this bug was found by @rtroilo
The text was updated successfully, but these errors were encountered: