Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix serializability of geometry filters #426

Merged
merged 5 commits into from
Sep 9, 2021

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Sep 8, 2021

Description

Fixes a serializability issue involving the geometry based filters (length: and area:).

This currently causes ohsome API queries to fail if they use these filters: example

Checklist

@tyrasd tyrasd added the bug Something isn't working as expected label Sep 8, 2021
@tyrasd tyrasd changed the title 🚧 fix serializability of geometry filters fix serializability of geometry filters Sep 9, 2021
@tyrasd tyrasd requested a review from rtroilo September 9, 2021 08:39
@tyrasd tyrasd added the waiting for review This pull request needs a code review label Sep 9, 2021
Copy link
Member

@rtroilo rtroilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a test, which could show us if there is a problem with serializability in our code.
Do we have a test that is capable to do so and or how much would be the effort to write such a test?

@tyrasd
Copy link
Member Author

tyrasd commented Sep 9, 2021

Do we have a test that is capable to do so

not at the moment

and or how much would be the effort to write such a test?

not sure how one would approach it. any suggestions?

@tyrasd tyrasd merged commit 439c94b into master Sep 9, 2021
@tyrasd tyrasd deleted the fix-serializability-geometry-filters branch September 9, 2021 09:22
tyrasd added a commit that referenced this pull request Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected waiting for review This pull request needs a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants