-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecations&cleanup #441
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtroilo
force-pushed
the
remove-deprecations-cleanup
branch
3 times, most recently
from
April 14, 2022 08:31
bc1ac10
to
a8d31bf
Compare
joker234
previously approved these changes
Apr 14, 2022
joker234
reviewed
Apr 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog missing
joker234
approved these changes
Apr 14, 2022
joker234
requested changes
Apr 14, 2022
joker234
previously approved these changes
Apr 14, 2022
Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org>
joker234
force-pushed
the
remove-deprecations-cleanup
branch
from
April 14, 2022 17:25
48ad666
to
68f2197
Compare
joker234
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove deprecated methods, class and some minor cleanups
removed deprecation
- MapReducerSettings (replaced by filter)osmTag(String key),osmTag(OSMTagInterface tag)osmTag(String key, String value),osmTag(String key, Collection values)osmTag(Collection<? extends OSMTagInterface> keyValuePairs)osmEntityFilter(OSMEntityFilter f) (filter(Filter.byOSMEntity(...)))Removing deprecate MapReducerSettings methods is unfortunately not straight forward, for example in
TestMapReducer.testOSMEntitySnapshotViewStream
we got following query.will throw an
the reason for that is that
filter(...)
instead ofosmTag(...)
adds a mapping step atoshdb/oshdb-api/src/main/java/org/heigit/ohsome/oshdb/api/mapreducer/MapReducer.java
Line 796 in 64bc0d8
which then conflicts with
groupByEntity
later on.Checklist
Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using
~...~
) and remove their checkboxes.