Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSHDB helpers integration #474

Merged
merged 15 commits into from
Nov 11, 2022
Merged

OSHDB helpers integration #474

merged 15 commits into from
Nov 11, 2022

Conversation

joker234
Copy link
Member

@joker234 joker234 commented Nov 4, 2022

Integrate the oshdb-database-driver consisting of an application template and a database driver into OSHDB helper modules

Description

See GitLab MR and documentation in documentation/manual/helpers.

Corresponding issue

Closes GitLab!18

New or changed dependencies

Checklist

Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using ~...~) and remove their checkboxes.

@joker234 joker234 added the enhancement New feature or request label Nov 4, 2022
@joker234 joker234 added this to the release 1.0 milestone Nov 4, 2022
@joker234 joker234 requested a review from rtroilo November 4, 2022 16:46
@joker234 joker234 force-pushed the oshdb-helpers-integration branch 3 times, most recently from 392493d to c0ce9bf Compare November 4, 2022 17:50
@SlowMo24
Copy link
Contributor

SlowMo24 commented Nov 7, 2022

our unit-tests could also go into the examples repository?

@joker234 joker234 added the waiting for review This pull request needs a code review label Nov 7, 2022
@joker234 joker234 requested review from SlowMo24 and removed request for rtroilo November 8, 2022 13:03
@joker234 joker234 removed the waiting for review This pull request needs a code review label Nov 9, 2022
@joker234 joker234 requested review from rtroilo and removed request for SlowMo24 November 10, 2022 13:11
@joker234 joker234 requested review from SlowMo24 and removed request for rtroilo November 10, 2022 17:41
joker234 and others added 8 commits November 11, 2022 16:19
Co-authored-by: Moritz Schott <moritz.schott@uni-heidelberg.de>
Co-authored-by: Moritz Schott <moritz.schott@uni-heidelberg.de>
Co-authored-by: Moritz Schott <moritz.schott@uni-heidelberg.de>
Co-authored-by: Moritz Schott <moritz.schott@uni-heidelberg.de>
Co-authored-by: Moritz Schott <moritz.schott@uni-heidelberg.de>
Co-authored-by: Moritz Schott <moritz.schott@uni-heidelberg.de>
Copy link
Member

@rtroilo rtroilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but we should create an issue to improve test for the OSHDBApplication as well.

@joker234 joker234 merged commit b8087a6 into master Nov 11, 2022
@joker234 joker234 deleted the oshdb-helpers-integration branch November 11, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants