-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSHDB helpers integration #474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joker234
force-pushed
the
oshdb-helpers-integration
branch
3 times, most recently
from
November 4, 2022 17:50
392493d
to
c0ce9bf
Compare
our unit-tests could also go into the examples repository? |
joker234
force-pushed
the
oshdb-helpers-integration
branch
from
November 8, 2022 13:03
080d130
to
ec8ffe5
Compare
joker234
force-pushed
the
oshdb-helpers-integration
branch
from
November 9, 2022 14:56
ec8ffe5
to
0184703
Compare
joker234
force-pushed
the
oshdb-helpers-integration
branch
from
November 10, 2022 10:23
0184703
to
fcb39cd
Compare
joker234
force-pushed
the
oshdb-helpers-integration
branch
from
November 10, 2022 17:37
9b1c1c6
to
32a74cd
Compare
rtroilo
reviewed
Nov 11, 2022
source: https://gitlab.gistools.geog.uni-heidelberg.de/giscience/big-data/ohsome/helpers/oshdb-database-driver/-/tree/prepare_release/ Co-authored-by: Moritz Schott <moritz.schott@uni-heidelberg.de>
Co-authored-by: Moritz Schott <moritz.schott@uni-heidelberg.de>
Co-authored-by: Moritz Schott <moritz.schott@uni-heidelberg.de>
Co-authored-by: Moritz Schott <moritz.schott@uni-heidelberg.de>
Co-authored-by: Moritz Schott <moritz.schott@uni-heidelberg.de>
Co-authored-by: Moritz Schott <moritz.schott@uni-heidelberg.de>
Co-authored-by: Moritz Schott <moritz.schott@uni-heidelberg.de>
Co-authored-by: Moritz Schott <moritz.schott@uni-heidelberg.de>
Co-authored-by: Moritz Schott <moritz.schott@uni-heidelberg.de>
new Dependency hikaricp
joker234
force-pushed
the
oshdb-helpers-integration
branch
from
November 11, 2022 15:21
32a74cd
to
c2cdf35
Compare
rtroilo
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but we should create an issue to improve test for the OSHDBApplication
as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate the oshdb-database-driver consisting of an application template and a database driver into OSHDB helper modules
Description
See GitLab MR and documentation in
documentation/manual/helpers
.Corresponding issue
Closes GitLab!18
New or changed dependencies
Checklist
[ ] I have adjusted the examples or created an issue in the corresponding repository[ ] I have adjusted the benchmark or created an issue in the corresponding repositoryPlease check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using
~...~
) and remove their checkboxes.