GeometryBuilder: add method to work with preresolved members #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the auxiliary data contains referenced child (and potentially child-child) entities of the entity to build the geometry of. in this case, these pre-resolved entities are used instead of the entity's own members data.
tyrasd
changed the title
* more verbosely/explicitly create empty geometries * handle all osm types equally in main entry point
tyrasd
force-pushed
the
geometrybuilder-preresolved-childs
branch
from
7493f83
to
bc67f33
Compare
* instead of static methods, the builder is instantiated with a TagInterpreter * change auxiliary data to lists * make a few more methods public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method to generate geometries of
OSMEntityobjects when their members are already known ("pre-resolved" for a dedicated timestamp). Also adds (or makes public) methods to explicitly create LineString / Polygon geometries forOSMWays, and MultiPolygon / GeometryCollection geometries forOSMRelations.These methods are bundled in a new
OSHDBGeometryBuilderInternalclass, which now also contains the concrete geometry building algorithms. For clarity and backwards compatibility, the mainOSHDBGeometryBuilderclass contains only the "default"getGeometrymethod (which works onentityplustimestamp) alongside the non-entity related geometry building methods .Checklist
I have made corresponding changes to the documentationI have adjusted the examples or created an issue in the corresponding repositoryI have adjusted the benchmark or created an issue in the corresponding repository