-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(map_generation): use aruco markers on sketch map #511
Conversation
7d28814
to
cb28532
Compare
9847136
to
21a48d1
Compare
91a4161
to
2477572
Compare
2477572
to
f87dae2
Compare
5576836
to
3b0b3a6
Compare
c4679e6
to
6b05c87
Compare
Optionally use aruco markers instead of globes on Sketch Maps. Every Aruco marker is unique (in contrast to the globes). Aruco markers can be used in clipping the map frame from uploaded sketch maps using as it is done currently using BRSIK or an marking detection algorithm provided by opencv2 in the future.
3975812
to
adf3688
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would maybe propose to use more complex Aruco markers in fututre in comparison to the 4x4 grid, as brisk relies on texture, and an 7x7 grid could be lead to a higher rate of succefull clippings. I will include this as a parameter in my future perfomance testing.
@itisacloud interesting, because the algorithm for detecting aruco markers from opencv works best if the markers are less complex. But its of course not in use at the moment. I am going to merge it, but feel free to change it if your testing found that it works better with complex markers. Or should this maybe be configurable?; Thank you for taking the time to review the PR! |
This PR consists of 4 parts:
It might be useful to review this PR commit by commit.
For now aruco markers instead of globes on Sketch Maps are optional. This feature flag is enabled by giving a query parameter
aruco=true
to the/create
endpoint (e.g.http://localhost:8081/en/create/aruco=true
).The advantage of Aruco markers might be:
This PR does adress in parts #488 and #502
Todo:
map_frames
to include attributearuco
defaulting toFALSE
-> Executed on the production database: