Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 3.6 and fix enum doc-string generation #36

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

josephmckinsey
Copy link
Contributor

@josephmckinsey josephmckinsey commented Jan 13, 2025

We were getting precompilation errors when trying to build the doc-strings. This is because we were using
Docs.doc which is now defined properly in REPL and not Base normally.

I've replaced that brittle implementation with another brittle implementation which will fail if they ever change
how docs are constructed in Base and will also fail if any doc-strings are missing for any Enums.

I also fixed an error in the tests about broker queries.

I've also updated the Project.toml with version 3.6.0 and deleted the Manifest.toml, which was really just screwing up our tests and nothing else. This causes a slight error in the tests about JSON formatting, which I've fixed.

Also, I would really like to remove the x86 tests.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.95%. Comparing base (fdfd48e) to head (0d1d80b).

Files with missing lines Patch % Lines
src/enums.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   62.73%   61.95%   -0.79%     
==========================================
  Files           6        6              
  Lines        1876     1861      -15     
==========================================
- Hits         1177     1153      -24     
- Misses        699      708       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephmckinsey josephmckinsey changed the title Fix enum doc-string generation Update to 3.6 and fix enum doc-string generation Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant