Respect PYHELICS_INSTALL #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Respect the PYHELICS_INSTALL environment variable as described in https://python.helics.org/installation/
kdheepak
reviewed
Oct 11, 2023
I like @kdheepak's suggestion for this a lot more than my original one. Thanks!! Co-authored-by: Dheepak Krishnamurthy <me@kdheepak.com>
|
I went ahead and added that suggestion into my branch, I do like that a lot more. Thanks for that 😄 |
kdheepak
reviewed
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When setting the PYHELICS_INSTALL environment variable, the setup.py will still attempt to download or build the HELICS binaries.
Expected Outcome
When setting PYHELICS_INSTALL, the setup.py should respect this and not proceed with downloading or building HELICS into
./helics/.Solution
Respect the PYHELICS_INSTALL environment variable as described in https://python.helics.org/installation/ by setting the PYHELICS_INSTALL variable in setup.py to the environment variable
PYHELICS_INSTALLif set, otherwise set to a default path of./helicsas previously set in the setup.py before.