Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python2 support #78

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Remove python2 support #78

merged 3 commits into from
Feb 9, 2024

Conversation

nightlark
Copy link
Member

Removes Python 2 jobs from release builds, required to get the job passing so new pyhelics 3.5 wheels can be published. Removes python2 specific code from setup.py, and cleans up some older Python 2 syntax for super().

Resolves #73

@nightlark nightlark self-assigned this Feb 9, 2024
@nightlark nightlark requested a review from kdheepak February 9, 2024 08:48
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (985cc1d) 63.84% compared to head (e0bf095) 63.86%.
Report is 1 commits behind head on main.

Files Patch % Lines
helics/capi.py 88.88% 1 Missing ⚠️
setup.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   63.84%   63.86%   +0.02%     
==========================================
  Files          27       27              
  Lines        8504     8502       -2     
==========================================
+ Hits         5429     5430       +1     
+ Misses       3075     3072       -3     
Flag Coverage Δ
unit 63.86% <81.81%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightlark nightlark merged commit 1ae7cb1 into main Feb 9, 2024
5 of 6 checks passed
@nightlark nightlark deleted the remove-python2-support branch February 9, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 2 support
3 participants