-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split web server into separate package #98
Conversation
josephmckinsey
commented
May 24, 2024
•
edited
Loading
edited
- Eliminated npm part in setup.py commands
- Created separate package
- rename to helics_cli_extras
- move observer stuff to helics_cli_extras
- move testing if necessary
- setup ci
- setup cd and PyPI package (🤞)
- Changed CI to run on push to main or pull request to main (prevents annoying duplication)
- Eliminated npm part in setup.py commands - Created separate package TODO - rename to helics_cli_extras - move observer stuff to helics_cli_extras - move testing if necessary - setup ci/cd and PyPI package
Relates to #86 For configuring the CI/CD workflow for this with PyPI publishing, use:
|
For backlog to make sdist eventually work: a custom in-source tree build backend interface that runs npm commands would likely be what we want. |
Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
P.S. I had to remove the python package "install" that was being added to our python dependencies in the github actions workflow. I believe it was never intended to be installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks so much nicer not having all that code just to run npm in the setup.py -- only thing I'm not sure about is if we should have checks for those two imports to return a nicer error message if a user tries to run those functions without installing the helics-cli-extras.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the workflow changes look okay -- after merging try triggering the workflow to publish an initial version of the helics-cli-extras package.