Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce ruler rerendering #467

Merged
merged 1 commit into from
Aug 17, 2019
Merged

Reduce ruler rerendering #467

merged 1 commit into from
Aug 17, 2019

Conversation

cmdcolin
Copy link
Collaborator

This is a sort of intricate stringing through of observer() that ends up reducing Ruler bar re-renderings

It also makes calculateStaticBlocks not return a new object if it is unchanged, which possibly could be done more intelligently, but it is effective in it's current state in reducing the re-renders

Addresses #434

@codecov
Copy link

codecov bot commented Aug 17, 2019

Codecov Report

Merging #467 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #467      +/-   ##
=========================================
+ Coverage   64.07%   64.1%   +0.03%     
=========================================
  Files         238     238              
  Lines        7752    7756       +4     
  Branches     1783    1784       +1     
=========================================
+ Hits         4967    4972       +5     
+ Misses       2559    2558       -1     
  Partials      226     226
Impacted Files Coverage Δ
...rc/LinearGenomeView/components/LinearGenomeView.js 62.37% <ø> (ø) ⬆️
...e-view/src/LinearGenomeView/components/ScaleBar.js 100% <100%> (ø) ⬆️
...-view/src/BasicTrack/components/BlockBasedTrack.js 85.71% <100%> (ø) ⬆️
...nome-view/src/LinearGenomeView/components/Ruler.js 96.61% <100%> (+0.05%) ⬆️
...ear-genome-view/src/BasicTrack/components/Block.js 100% <100%> (ø) ⬆️
...nome-view/src/BasicTrack/components/TrackBlocks.js 71.42% <100%> (ø) ⬆️
...s/linear-genome-view/src/LinearGenomeView/index.js 90.72% <100%> (+0.18%) ⬆️
packages/core/util/index.ts 59.68% <0%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11cac4d...f12e90d. Read the comment docs.

@cmdcolin cmdcolin force-pushed the reduce_ruler_rerendering branch 2 times, most recently from eb9d315 to dc9b105 Compare August 17, 2019 01:37
@cmdcolin cmdcolin force-pushed the reduce_ruler_rerendering branch from dc9b105 to f12e90d Compare August 17, 2019 01:46
@cmdcolin
Copy link
Collaborator Author

Merging because the performance looks so good after merge

@cmdcolin cmdcolin merged commit 6bbca94 into master Aug 17, 2019
@cmdcolin cmdcolin deleted the reduce_ruler_rerendering branch August 22, 2019 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant