Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to load a ?hubURL= from URL bar #4745

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Add ability to load a ?hubURL= from URL bar #4745

merged 5 commits into from
Jan 7, 2025

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jan 2, 2025

This is a demonstration of loading a UCSC trackhub from the URL bar using &hubURL

It may not be the final word on this but there a number of "interesting" concerns it has to handle

  • The hubURL works without any config.json being loaded. In fact, it currently bypasses any config loading, and just creates an empty config, empty session, and loads the hub as a sessionConnection
  • To accomplish the above, the hubURL goes through an entirely separate path in the "SessionLoader" (session loader normally processes the URL parameters and such) and as a result of some of the choices here, this means that currently hubURL is not "composable" with other existing URL params e.g. you can't use &loc and &hubURL unless i reimplement &loc for &hubURL, etc.

It's possible that some of the above design choices could be reconsidered, but I wanted to have a demo of hubURL for the UCSC<->JBrowse interop for PAG :)

@cmdcolin cmdcolin force-pushed the huburl branch 3 times, most recently from 97f9133 to 8240626 Compare January 6, 2025 15:57
@cmdcolin cmdcolin merged commit e150c03 into main Jan 7, 2025
4 checks passed
@cmdcolin cmdcolin deleted the huburl branch January 7, 2025 15:42
@cmdcolin cmdcolin added the enhancement New feature or request label Jan 16, 2025
@cmdcolin cmdcolin restored the huburl branch January 28, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant