Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node-sass to help avoid some install issues #1607

Closed
wants to merge 3 commits into from

Conversation

cmdcolin
Copy link
Contributor

Similar to GMOD/jbrowse-components#2062

This uses sass-loader@^10 which depends on sass instead of node-sass, which is a pure-js implementation of sass and doesn't spin up c compilers, etc.

The version sass-loader@^10 is similar to what is used by current react-scripts@^4

@cmdcolin

This comment has been minimized.

@cmdcolin
Copy link
Contributor Author

this one actually does not look right, may have to be closed

localhost_jbrowse__loc=1%3A14399 31413 tracks=testing highlight=

@cmdcolin cmdcolin closed this Jun 21, 2021
@cmdcolin
Copy link
Contributor Author

Note added to README describing that users may need to use node 14 or less to install jbrowse from github, and might also apply to users using plugins or dev versions of jbrowse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant