do not render a date when date fields empty #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix an issue with rendering unspecified "auxiliary dates", which are dates that belong to other columns
Without making sure that a date is present, the app currently outputs 1/01/1970, 12:00:00 pm which is the result of
new Date(null), as can be seen here for example for the record 810 (https://tsunami.gns.cri.nz/#!/db/r810)The fix will check for the presence of both min and max dates and if not present outputs an mdash (—) as used elsewhere for missing data (and also removes the obsolete (and unspecified) certainty value. The result can be seen here: