Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/rates #23

Merged
merged 17 commits into from
Nov 27, 2023
Merged

Fix/rates #23

merged 17 commits into from
Nov 27, 2023

Conversation

chrisdicaprio
Copy link
Collaborator

@chrisdicaprio chrisdicaprio commented Nov 26, 2023

  • input slip rates are now inversion target not raw (target can be different from raw by, e.g. application of slip_factor)
  • column names identify if a slip rate is a target or solution

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8fdd9eb) 90.10% compared to head (71100c2) 90.21%.

❗ Current head 71100c2 differs from pull request most recent head 2f0df14. Consider uploading reports for the commit 2f0df14 to get more accurate results

Files Patch % Lines
solvis/solvis.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   90.10%   90.21%   +0.11%     
==========================================
  Files          14       14              
  Lines         768      787      +19     
  Branches       59       60       +1     
==========================================
+ Hits          692      710      +18     
  Misses         68       68              
- Partials        8        9       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisbc
Copy link
Member

chrisbc commented Nov 27, 2023

@chrisdicaprio just remember the changelog & bumpversion pls :)

@chrisdicaprio chrisdicaprio merged commit 2e89ef7 into main Nov 27, 2023
0 of 6 checks passed
@chrisdicaprio chrisdicaprio deleted the fix/rates branch November 27, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants