Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/42 participation rate filter #48

Merged
merged 56 commits into from
Oct 28, 2024

Conversation

chrisbc
Copy link
Member

@chrisbc chrisbc commented Sep 19, 2024

closing #42 and closing #46 this PR includes:

  • new style filter package to standardise and improve filtering on various aspects of the solution datasets.
  • conditional vs non-conditional participaton
  • many docstrings and mkdocs improvements
  • test optimisations
  • dataframe models using the panderas library

chrisbc added 30 commits July 24, 2024 07:52
…yvista libs; changes to read_csv_dtype configuration; detox
… migrate old functions and deprecate warn the originals;
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 93.99293% with 34 lines in your changes missing coverage. Please review.

Please upload report for BASE (pre-release@a5666e0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
solvis/inversion_solution/named_fault.py 0.00% 11 Missing ⚠️
...nversion_solution/inversion_solution_operations.py 92.59% 5 Missing and 1 partial ⚠️
solvis/solvis.py 63.63% 4 Missing ⚠️
...lvis/inversion_solution/inversion_solution_file.py 91.42% 2 Missing and 1 partial ⚠️
solvis/fault_system_solution_helper.py 93.33% 0 Missing and 2 partials ⚠️
solvis/filter/chainable_set_base.py 96.77% 1 Missing and 1 partial ⚠️
solvis/filter/rupture_id_filter.py 97.70% 1 Missing and 1 partial ⚠️
solvis/inversion_solution/dataframe_models.py 98.34% 1 Missing and 1 partial ⚠️
solvis/inversion_solution/typing.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             pre-release      #48   +/-   ##
==============================================
  Coverage               ?   91.57%           
==============================================
  Files                  ?       22           
  Lines                  ?     1305           
  Branches               ?      114           
==============================================
  Hits                   ?     1195           
  Misses                 ?       86           
  Partials               ?       24           
Flag Coverage Δ
unittests 91.57% <93.99%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisbc chrisbc marked this pull request as ready for review October 22, 2024 21:54
@chrisbc chrisbc requested a review from chrisdicaprio October 22, 2024 21:54
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
solvis/filter/parent_fault_id_filter.py Show resolved Hide resolved
solvis/filter/rupture_id_filter.py Show resolved Hide resolved
solvis/geometry.py Outdated Show resolved Hide resolved
solvis/inversion_solution/inversion_solution_operations.py Outdated Show resolved Hide resolved
solvis/inversion_solution/inversion_solution_operations.py Outdated Show resolved Hide resolved
solvis/inversion_solution/inversion_solution_operations.py Outdated Show resolved Hide resolved
solvis/inversion_solution/dataframe_models.py Outdated Show resolved Hide resolved
@chrisbc chrisbc merged commit 1cbdb91 into pre-release Oct 28, 2024
11 checks passed
@chrisbc chrisbc deleted the feature/42_participation_rate_filter branch October 28, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants