-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/49 named fault participation #67
base: pre-release
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pre-release #67 +/- ##
===============================================
+ Coverage 99.29% 99.31% +0.02%
===============================================
Files 23 23
Lines 1273 1317 +44
Branches 62 68 +6
===============================================
+ Hits 1264 1308 +44
Misses 8 8
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c74b96c
to
c9108e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good @chrisbc just a comment and a Q (with a scope outside this PR, I think)
@@ -260,6 +261,7 @@ def ruptures(self) -> 'DataFrame[RuptureSchema]': | |||
return cast('DataFrame[RuptureSchema]', df) | |||
|
|||
@property | |||
@lru_cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider using functools.cache
new in py3.9 (which is min python for solvis
) https://docs.python.org/3/library/functools.html#functools.cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there anything that ensures the mapping is only applied to models where it is correct? What happens if a new CFM with new named faults is introduced?
NB
rebase this once #66 is mergedDONE