Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/49 named fault participation #67

Open
wants to merge 7 commits into
base: pre-release
Choose a base branch
from

Conversation

chrisbc
Copy link
Member

@chrisbc chrisbc commented Jan 30, 2025

NB rebase this once #66 is merged DONE

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.31%. Comparing base (f635311) to head (8ed3f22).
Report is 2 commits behind head on pre-release.

Additional details and impacted files
@@               Coverage Diff               @@
##           pre-release      #67      +/-   ##
===============================================
+ Coverage        99.29%   99.31%   +0.02%     
===============================================
  Files               23       23              
  Lines             1273     1317      +44     
  Branches            62       68       +6     
===============================================
+ Hits              1264     1308      +44     
  Misses               8        8              
  Partials             1        1              
Flag Coverage Δ
unittests 99.31% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisbc chrisbc force-pushed the feature/49_named_fault_participation branch from c74b96c to c9108e6 Compare February 2, 2025 21:57
@chrisbc chrisbc marked this pull request as ready for review February 3, 2025 05:12
@chrisbc chrisbc requested a review from chrisdicaprio February 3, 2025 21:51
Copy link
Collaborator

@chrisdicaprio chrisdicaprio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @chrisbc just a comment and a Q (with a scope outside this PR, I think)

@@ -260,6 +261,7 @@ def ruptures(self) -> 'DataFrame[RuptureSchema]':
return cast('DataFrame[RuptureSchema]', df)

@property
@lru_cache
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider using functools.cache new in py3.9 (which is min python for solvis) https://docs.python.org/3/library/functools.html#functools.cache

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there anything that ensures the mapping is only applied to models where it is correct? What happens if a new CFM with new named faults is introduced?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants