-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1주차 기본/심화 과제] 웨비들의 냠냠 🍰 창업🏠 #1
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
544daa3
docs : 전체 태그 구조 작성
simeunseo fe6f7fd
init : css 세팅
simeunseo 3569270
style : 글꼴 세팅
simeunseo bd18121
style : 글꼴 변경, header 완료
simeunseo 0197280
style : nav 완료
simeunseo aa8c605
style : cards 및 반응형 완료
simeunseo 815936c
style : 찜하기 버튼 오른쪽 정렬, 호버이벤트
simeunseo b1ad23a
style : 넘치는 해시태그 가리기, 전체적 디테일 수정
simeunseo 188f9f3
style : 글꼴 수정, header 세로정렬
simeunseo 4aa3a67
docs : img 태그에 alt 추가
simeunseo 02bca98
refactor : 넘치는 해시태그 자르기
simeunseo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -213,11 +213,18 @@ header { | |
font-weight: bold; | ||
} | ||
|
||
#header__menu > h2 { | ||
padding-bottom: 1rem; | ||
#header__menu > h3 { | ||
padding-bottom: 1.5rem; | ||
cursor: pointer; | ||
} | ||
|
||
#header__menu > h3:hover { | ||
text-decoration-line: underline; | ||
text-decoration-style: wavy; | ||
text-decoration-color: var(--main-color); | ||
text-underline-offset: 0.3rem; | ||
Comment on lines
+233
to
+236
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 진짜 디테일한데?! |
||
} | ||
|
||
/* nav */ | ||
main { | ||
padding: 2rem; | ||
|
@@ -325,3 +332,10 @@ img { | |
.cards__card i:hover { | ||
color: var(--main-color); | ||
} | ||
|
||
.cards__card small { | ||
width: 9rem; | ||
white-space: nowrap; | ||
overflow: hidden; | ||
text-align: center; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class를 지어줄 때 은서만의 규칙같은 게 있는 걸까? 언더바 두개를 쓴 이유도 특별한 규칙이 있는 건지 궁금해 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거는 세미나에서 언급됐던 BEM 방법론을 이용한거야! https://velog.io/@fromzoo/css-%EB%B0%A9%EB%B2%95%EB%A1%A0-BEM-%EB%B0%A9%EC%8B%9D
이렇게 하면 규칙도 생기고(협업할 때 좋쥐), 이름만으로도 구조화가 되어서 좋아 ㅎㅎ