-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ 1주차 기본/심화 과제 ] : assign3 - 웨비들의 냠냠 🍰 창업🏠 (Yeonsinsa 👗👖👚) #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
옷을 조아하는 연서였구나>.< ㅎㅎㅎㅎ 옷은 사도사도 모자르긴하지ㅋㅎㅎㅋㅎㅋ
bem도 노력해서 명명한게 느껴진당!!! 넘 고생해떠 ㅎㅎ
<ul class="cards__tagwrapper"> | ||
<li class="cards__tag">#디젤피카부</li> | ||
<!-- 넘치는 태그는 안보이게 처리--> | ||
<li class="cards__tag">#태그길게길게넘치나안넘치나테스트</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 ::before content사용하면 #없앨수이써용 ㅎㅎ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 그런 방법이 있었구나! 이번 주 과제 하면서 고쳐볼겡 고마오 🫶🏻
justify-content: center; | ||
align-items: center; | ||
overflow: hidden; | ||
word-break: keep-all; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
꺄웅!! 넘 야무진데?!
index.html
Outdated
@@ -1,10 +1,10 @@ | |||
<!DOCTYPE html> | |||
<html lang="en"> | |||
<html lang="ko"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 디테일해 ㅎㅎ
index.html
Outdated
<input type="checkbox" /> | ||
<h3>ALL</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
input label 사용하는게 더 적절한것가타! 여기서 all은 input 체크박스에 대한 설명이니까?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맞네 맞네 안그래도 여기에 h태그를 쓰는게 맞는지 긴가민가 했는데 바꿔봐야게써
index.html
Outdated
<section class="header__menu"> | ||
<article class="header__list"> | ||
<h2 class="header__sublist-title">메뉴</h2> | ||
<br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헉 그렇구나 ,,! br 사용은 최대한 지양해야겠당
index.html
Outdated
<!--card1--> | ||
<article> | ||
<article class="cards__card"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앙!! 몬가 복수단수 가 나열되어있어서 첨에 살짝쿵 잘 안와닿앗던것가타..! 음음 나라면 cards__cardItem
이라고 하거나 cards__cardContent
정도로 중복 단어를 완화(?)시켜줬을것가튼데 이거에대해서는 어떻게 또 생각할지 궁금하넹!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
흠 마자 나도 이게 고민이었는데!! cardItem이나 cardContent가 더 적절한것 같넹 !👍
index.html
Outdated
<!--card2--> | ||
<article> | ||
<header> | ||
<h2>사고싶은데 못구하는거</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
하놬ㅎㅋㅎㅋㅎㅋㅎ
index.html
Outdated
<h2 class="nav__title">CATEGORY</h2> | ||
<section class="nav_content"> | ||
<article class="nav__category"> | ||
<input type="checkbox" class="nav__checkbox" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bem방법론 조금더 디테일하게 하면 사실 여기서부터는 input이 article태그의 자식이니까 nav 밑의 블록으로 표현하기보다는
<input type="checkbox" class="nav__checkbox" /> | |
<input type="checkbox" class="nav__category__checkBox"/> |
가 조콤더 명확하게 보이겠찌?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bem 방법론 요기 링크 참고했는데
여기서 계층 구조로 선언하는 것은 추천하지 않아서 이렇게 이름 지었던거여써! 어떤게 더 적절한 방법일까 고민되네 💭..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
완전 수고했어!! 다음 주차도 힘내자구..!
</nav> | ||
|
||
<section class="cards"> | ||
<!--card1--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요렇게 주석 달아서 구분한거 좋다...나는 css에서만 이렇게 구분했는데 앞으로는 html도 요래 적용해야지! 꿀팁 고마우
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 사실 내가 헷갈려서 달아놓았던건데 ㅎㅎ 고마웅
<!-- 넘치는 태그는 안보이게 처리--> | ||
<li class="cards__tag">#태그길게길게넘치나안넘치나테스트</li> | ||
</ul> | ||
<img class="cards__img" src="./img/disel.jpg" alt="디젤 반팔티" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
img alt 작성할 때 html에서는 하이픈(-)을 띄어쓰기로 인식하니까 띄어쓰기 대신에 하이픈 사용해주는게 웹 접근성을 고려했을 때 더 좋은 방법이라고 하네요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 그렇구낭 !! 바로 수정해야겠다 고마어
@@ -0,0 +1,220 @@ | |||
@font-face { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요 위에 GLOBAL 이나 CONFIG 같은 주석 달아줘도 좋을 것 같아!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
마자마자 깜빡했다! 꼼꼼히 봐줘서 고마웅
padding: 0 1.5rem; | ||
} | ||
|
||
/* 반응형 구현 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아주 섬세하네...나도 이렇게 했어야 했는데..잘 했다!!
<header> | ||
<h2>WishList 2</h2> | ||
</header> | ||
<ul class="cards__tagwrapper"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tag를 div로만 생각했는데 li태그가 훨씬 맞겠네요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
마자 나도 span으로 했다가 li로 고쳤었어 !!
✨ 구현 기능 명세
header , nav, card section
으로 나누어 구현합니다. ☑️space-between
를 사용합니다. ☑️전체, 분류1, 분류2, 분류3
총4가지로 구현됩니다. ☑️flex 또는 grid
를 사용하여 배치합니다. ☑️상품제목, 해시태그 목록, 이미지, 하트 찜 누르기
가 들어있습니다. ☑️단 . 마지막 한줄 정렬시 가운데로 상품 카드 레이아웃이 변경됩니다. ☑️
🌼 PR Point
📍 header 상단 고정
📍 header 메뉴바
📍 특정 길이를 벗어나면 뒤의 태그 숨기기
📍 반응형 레이아웃
📍 BEM 패턴
🥺 소요 시간, 어려웠던 점
3h
🌈 구현 결과
week1_assign3.mov