-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GT-182] Add restrictions on who can create SG's #460
[GT-182] Add restrictions on who can create SG's #460
Conversation
htdocs/web_portal/controllers/service_group/add_service_group.php
Outdated
Show resolved
Hide resolved
htdocs/web_portal/controllers/service_group/add_service_group.php
Outdated
Show resolved
Hide resolved
htdocs/web_portal/controllers/service_group/add_service_group.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm i think, but Greg or someone else should give it a look over before merging
htdocs/web_portal/controllers/service_group/add_service_group.php
Outdated
Show resolved
Hide resolved
htdocs/web_portal/controllers/service_group/add_service_group.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two minor changes :)
htdocs/web_portal/controllers/service_group/add_service_group.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from what i just reviewed, lgtm
084cfee
to
267c11c
Compare
96f4f8b
to
74ec607
Compare
Ready to be reviewed. |
61856ae
to
64051b2
Compare
Looks good to me, can you remove "(F)" from the commit message please? |
64051b2
to
efb4063
Compare
Done. I have reworded the commit. The reason I have added is I wanted to differentiate styles vs functionality. |
efb4063
to
8922db3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rebasing on top of latest dev |
8922db3
to
7b85831
Compare
If a user is an
Admin
-> they are allowed to ADD new service group's.If a user is NOT an
Admin
:Resolves #364