Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GT-182] Add restrictions on who can create SG's #460

Merged

Conversation

Sae126V
Copy link
Contributor

@Sae126V Sae126V commented Jul 7, 2023

If a user is an Admin -> they are allowed to ADD new service group's.

If a user is NOT an Admin:

  1. Case1: User is NOT allowed to add new SG's. If a User have no roles assigned.
  2. Case2: User is allowed to add new SG's. If a user is registered and have at least one role assigned with 'STATUS_GRANTED'.

Resolves #364

@Sae126V Sae126V requested a review from a team as a code owner July 7, 2023 09:35
@Sae126V Sae126V requested a review from rowan04 July 10, 2023 15:52
@Sae126V Sae126V requested a review from rowan04 July 11, 2023 16:06
Copy link
Member

@rowan04 rowan04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm i think, but Greg or someone else should give it a look over before merging

Copy link
Member

@gregcorbett gregcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor changes :)

@gregcorbett gregcorbett self-assigned this Aug 14, 2023
Copy link
Member

@rowan04 rowan04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from what i just reviewed, lgtm

@Sae126V Sae126V force-pushed the GT-182-Restrict-who-can-create-Service-Groups branch from 084cfee to 267c11c Compare August 24, 2023 07:42
@Sae126V Sae126V force-pushed the GT-182-Restrict-who-can-create-Service-Groups branch 2 times, most recently from 96f4f8b to 74ec607 Compare September 8, 2023 12:29
@Sae126V
Copy link
Contributor Author

Sae126V commented Sep 8, 2023

Ready to be reviewed.

@Sae126V Sae126V force-pushed the GT-182-Restrict-who-can-create-Service-Groups branch from 61856ae to 64051b2 Compare September 8, 2023 16:53
@gregcorbett
Copy link
Member

Looks good to me, can you remove "(F)" from the commit message please?

@Sae126V Sae126V force-pushed the GT-182-Restrict-who-can-create-Service-Groups branch from 64051b2 to efb4063 Compare September 11, 2023 10:04
@Sae126V
Copy link
Contributor Author

Sae126V commented Sep 11, 2023

Looks good to me, can you remove "(F)" from the commit message please?

Done. I have reworded the commit. The reason I have added is I wanted to differentiate styles vs functionality.

@Sae126V Sae126V force-pushed the GT-182-Restrict-who-can-create-Service-Groups branch 2 times, most recently from efb4063 to 8922db3 Compare September 11, 2023 10:18
@gregcorbett gregcorbett added this to the May 2023 milestone Sep 11, 2023
Copy link
Member

@gregcorbett gregcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregcorbett
Copy link
Member

rebasing on top of latest dev

@gregcorbett gregcorbett force-pushed the GT-182-Restrict-who-can-create-Service-Groups branch from 8922db3 to 7b85831 Compare September 11, 2023 10:53
@gregcorbett gregcorbett merged commit 643461f into GOCDB:dev Sep 11, 2023
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restrict who can create ServiceGroups
3 participants