Mechanically remove QStringRef use for QStringView to help with Qt6. #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make more string literals encoded at UTF-16 (bloaty-bytes) to reduce conversions. * Favor QStringView(Qt6-ism that mirrors C++ standard std::stringview) over QStringRef (Qt5 hack).
tsteven4
added a commit
that referenced
this pull request
Sep 27, 2021
… help with Qt6. (#723) * Fix typo in maggeo from search-and-replace work earlier. * Revert startOfDate() calls to keep floor at 5.12.x to keep builders happy. :-/ * Explictly get QString from StringView in gpx for compat with older Qt builds. Co-authored-by: Robert Lipe <robertlipe@gmail.com>
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduce conversions.
over QStringRef (Qt5 hack).