update root descriptor offset after link/merge #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
kuhar
reviewed
Mar 3, 2020
Test summary for commit 2c15839Driver commits used in build
ShaderDB test
CTS tests (built with branch Vulkan-CTS-1.2.0.2-fetch-sources-fix)
Rhel 7.6, Vega10Ubuntu 18.04, Navi10Ubuntu 18.04, Ellesmere |
amingriyue
force-pushed
the
dev1
branch
2 times, most recently
from
c032a18
to
17ce2cb
Compare
Test summary for commit c032a18Driver commits used in build
ShaderDB test
CTS tests (built with branch Vulkan-CTS-1.2.0.2-fetch-sources-fix)
Rhel 7.6, Vega10Ubuntu 18.04, Navi10Ubuntu 18.04, Ellesmere |
Test summary for commit 17ce2cbDriver commits used in build
ShaderDB test
CTS tests (built with branch Vulkan-CTS-1.2.0.2-fetch-sources-fix)
Rhel 7.6, Vega10Ubuntu 18.04, Navi10Ubuntu 18.04, Ellesmere |
kuhar
reviewed
Mar 3, 2020
Test summary for commit 8746bb2Driver commits used in build
ShaderDB test
CTS tests (built with branch Vulkan-CTS-1.2.0.2-fetch-sources-fix)
Rhel 7.6, Vega10Ubuntu 18.04, Navi10Ubuntu 18.04, Ellesmere |
Test summary for commit 4baf50cDriver commits used in build
ShaderDB test
CTS tests (built with branch Vulkan-CTS-1.2.0.2-fetch-sources-fix)
Rhel 7.6, Vega10Ubuntu 18.04, Navi10Ubuntu 18.04, Ellesmere |
|
ping... |
|
there is conflicts, please rebase. |
|
@kuhar please review this patch |
amdrexu
reviewed
Mar 5, 2020
|
Also, a rebase is needed because llpc.h is changed. |
|
rebased with Tim's separation, some constant needs to be defined in two places(llpcUtil.h and llpcInternal.h), seems it doesn't make sense. Is that expected? |
llpcUtil.h is for front-end definitions. llpcInternal.h is for middle-end definitions, and will soo be moving, with the whole of the middle-end, into a different directory. The multiple definition problem is caused by the elf linking code being in the wrong place -- it should really be in the middle-end. But we're not going to fix that short-term, so for now let's leave the multiple definitions. |
I'm not familiar with these parts of the codebase the code touches, so I only commented about some nits I found without approving the patch. I don't see any issues in the current revision. |
amdrexu
approved these changes
Mar 6, 2020
|
build failure: |
fill descriptor magic number and set number to USER_DATA registers,
accordingly update offset after link/merge
v2:
a. fix cts failures(care userDataLimit).
b. add option to decide if enable this feature.
c. add mask to get Magic and set.
d. improve coding style.
v3: rebase
Signed-off-by: Chunming Zhou <david1.zhou@amd.com>
Test summary for commit 85f386bDriver commits used in build
ShaderDB test
CTS tests (built with branch Vulkan-CTS-1.2.0.2-fetch-sources-fix)
Rhel 7.6, Vega10Ubuntu 18.04, Navi10 |
nhaehnle
reviewed
Mar 9, 2020
| @@ -1320,6 +1334,19 @@ uint32_t GraphicsShaderCacheChecker::Check( | |||
| return stageMask; | |||
| } | |||
|
|
|||
| // ===================================================================================================================== | |||
| // Update root level descriptor offset for graphics pipeline. | |||
| void GraphicsShaderCacheChecker::UpdateRootUserDateOffset( | |||
Comment on lines
+243
to
+244
| // Whether update descriptor root offset in ELF | ||
| bool updateDescInElf; |
There was a problem hiding this comment.
Can you provide a more useful comment?
it has been merged, do you need I make another patch or just drop your comments? :) |
|
I'm still trying to understand some of the details of how this is going to be used. I will follow up. |
nhaehnle
pushed a commit
to nhaehnle/llpc
that referenced
this pull request
Apr 7, 2020
…/merge
fill descriptor magic number and set number to USER_DATA registers,
accordingly update offset after link/merge
v2:
a. fix cts failures(care userDataLimit).
b. add option to decide if enable this feature.
c. add mask to get Magic and set.
d. improve coding style.
v3: rebase
Signed-off-by: Chunming Zhou <david1.zhou@amd.com>
Pull Request: GPUOpen-Drivers#488
OVS = http://ocltc.amd.com:8111/viewModification.html?modId=132590&personal=true&init=1&tab=vcsModificationTests
git-pf-change: stg@2081347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fill descriptor magic number and set number to USER_DATA registers,
accordingly update offset after link/merge
v2:
a. fix cts failures(care userDataLimit).
b. add option to decide if enable this feature.
c. add mask to get Magic and set.
d. improve coding style.
Signed-off-by: Chunming Zhou david1.zhou@amd.com