-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the guts of gplately.download.DataServer
with plate-model-manager
#141
base: master
Are you sure you want to change the base?
Conversation
IMPORTANT: I had to run |
@michaelchin is nearly ready to merge. The only problem I have is that |
Maybe replace |
This is inside the |
Hi @michaelchin - do you have any suggestions about the above issue? I think this could be a blocker for the next gplately release until we sort it out. Ideally it would be best if existing plate models downloaded by the old DataServer object could be overwritten... |
Yes, if the new and old files have the same paths and names, I guess it would be possible to overwrite the old ones with the new ones. Otherwise, we may need to track the old files somehow... |
@michaelchin - Can you take over this PR? I don't have capacity any more and I am lost on how to get the new DataServer (powered by plate-model-manager) to overwrite old cached plate reconstructions. |
Sure, no problem. |
plate-model-manager is the new way (and the best way) to download plate models, age grids, and spreading rate grids. However, a lot of legacy workflows rely on the
DataServer
object in gplately. Currently, there are some advantages of retainingDataServer
that perhaps will be propagated upstream:pygplates.RotationModel
is returned instead of a list of rotation filenames.pygplates.FeatureCollection
is returned instead of a list of topology filenames. Same applies for static polygons, coastlines, COBs, etc.gplately.Raster
is returned instead of a list of age grid / spreading rate grid filenames.DownloadWarning
.This wrapping of
plate-model-manager
implements lazy loading, where files are only downloaded when requested. These rotation models, topologies, etc. are accessed like attributes (using the@property
decorator).