Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing Intellisense #2

Closed
runxel opened this issue Jul 12, 2021 · 5 comments
Closed

Confusing Intellisense #2

runxel opened this issue Jul 12, 2021 · 5 comments
Labels
enhancement New feature or request
Milestone
v25.2

Comments

@runxel
Copy link
Contributor

runxel commented Jul 12, 2021 •
edited
Loading

So nice to have that Intellisense support! I like it.

But the general layout could be improved.
Also I highly dislike the parameter type (RealNum in the example screenshot) being so intrusive in the Intellisense.
Look, actually this info belongs to the icon (whats now a generic box), and certainly not in the intellisense text! So instead of the box there should be the icon of the appropiate type.

intellisense1

Even if you decide to leave it (which you really shouldn't), the order would still be wrong. I'm looking for a certain parameter so clearly the RealNum must not be named first....

And maybe the description of the parameter would do fine without the quotes wrapped around it.
@pbaksa
Copy link
Contributor

pbaksa commented Jul 27, 2021

Adding the parameter type to the text is useful because this allows parameter filtering by type. It could be after the parameter name.
I couldn't find how to customize icons, the existing ones are useless for the GDL parameter types. The type selection is done by the API CompletionItemProvider returning CompletionItemKind, no way to customize it's icon.

@runxel runxel mentioned this issue Jul 27, 2021
Closed
@runxel
Copy link
Contributor Author

runxel commented Jul 27, 2021

Adding the parameter type to the text is useful because this allows parameter filtering by type. It could be after the parameter name.

By "filtering" you mean typing in e.g. len_creal (to take the example from the screenshot), or what?
(I actually can't test that right now, because intellisense has stopped working for me... no idea why, tho.)

🤔 Mh. Not that I would need that, but I can see that some few people might find it useful.

Still: This info clearly is not the info I want at the first place! It is a bit out of order.
How about writing:

param_name    (type)

I opened an issue at the VSC repo so maybe in the future we can register our own icons.

@pbaksa
Copy link
Contributor

pbaksa commented Jul 28, 2021

I meant typing LineType to see all linetype attribute parameters.
It works only with HSF gdl files and Ctrl-Alt-Space turns it on/off. If there is a bug and you can find a repro please report it.
I think I tried showing types at the end, but multiple spaces were collapsed to one. Parentheses might help visualy.

@runxel
Copy link
Contributor Author

runxel commented Jul 28, 2021 •
edited
Loading

I meant typing LineType to see all linetype attribute parameters.

Ah yes, okay. Now I understand. Thanks for clarification.
This might indeed be useful, especially when there are alot of the same type.

That was a weird one. Yesterday it refused to work, but today everythings fine again. ¯\_(ツ)_/¯
Thanks anyway!

@pbaksa pbaksa added the enhancement New feature or request label Nov 2, 2021
@pbaksa pbaksa added this to the v25.2 milestone Nov 2, 2021
@pbaksa pbaksa closed this as completed Nov 29, 2021
@pbaksa
Copy link
Contributor

pbaksa commented Nov 29, 2021

Thank you for contributing!

pbaksa added a commit that referenced this issue Feb 14, 2023
@pbaksa
# This is a combination of 11 commits.
219f762 
# This is the 1st commit message:

use constants from currently edited text

# This is the commit message #2:

search definitions in master script
search references from master in other scripts

# This is the commit message #3:

find other references from selected reference
use extra parser for subroutine calls (don't include yet in symbols)

# This is the commit message #4:

use current edited version of HSF files

# This is the commit message #5:

Show all definitions / references, even erroneous

# This is the commit message #6:

use HSFLibpart to handle other scripts of libpart
don't use extension setting for intellisense filtering

# This is the commit message #7:

Revert "use HSFLibpart to handle other scripts of libpart"

This reverts commit 32463ec.

# This is the commit message #8:

Revert "Show all definitions / references, even erroneous"

This reverts commit 1ca043e.

# This is the commit message #9:

Revert "use current edited version of HSF files"

This reverts commit 7a04743.

# This is the commit message #10:

Revert "find other references from selected reference"

This reverts commit 4721353.

# This is the commit message #11:

Revert "search definitions in master script"

This reverts commit 317be45.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v25.2
Development

No branches or pull requests
2 participants
@runxel @pbaksa