add support for semver crate #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @GREsau |
OmarTawfik
changed the title
|
Added a Regex pattern for the resulting string type, which is a permissive version of the official spec at: https://semver.org/ |
20 tasks
|
@GREsau I wonder if you have time to take a look. |
|
It seems like the project is still active, with new updates this week. Would love to see this shipped! @GREsau Thanks for all the hard work maintaining this incredibly useful crate! |
|
Can this use the official validation regex? Doesn't seem like there's a particular reason not to. |
|
@sunshowers you are absolutely correct. updated! |
|
This is largely the same as #182 |
|
@jayvdb How so? |
|
oh sorry wrong one - I meant #74 |
This was referenced Aug 27, 2023
Closed
|
Merged in #238, better late than never right? 😅 Thanks for the PR |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the awesome package!
This PR adds support for the
semvercrate, which is a Rust-wide standard now for reading/writing/comparing/validating versions. It also has its ownserdefeature for serializing/deserializingVersiontypes into JSON strings.Any comments/feedback is really appreciated. Would love to merge this and integrate it into our own projects!