-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support enumflags2::BitFlags and optional x-enumNames extension #221
Open
andrew-lee-architect
wants to merge
26
commits into
GREsau:master
Choose a base branch
from
andrew-lee-architect:x-enum-names
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support enumflags2::BitFlags and optional x-enumNames extension #221
andrew-lee-architect
wants to merge
26
commits into
GREsau:master
from
andrew-lee-architect:x-enum-names
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-lee-architect
changed the title
Support enumflags2
Support enumflags2::BitFlags and optional x-enumNames extension
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support creating more useful schemas for BitFlags types as define by the enumflags2 crate, by including the original enum in definitions. Also, add support for "x-enumNames" extension to JSON-Schema to preserve enum names for toolchains that support it. The extension works for any enum container.
Added a unit test demonstrating both features.