Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schemas for bigdecimal/rust_decimal #248

Merged
merged 2 commits into from
Sep 17, 2023
Merged

Fix schemas for bigdecimal/rust_decimal #248

merged 2 commits into from
Sep 17, 2023

Conversation

GREsau
Copy link
Owner

@GREsau GREsau commented Sep 17, 2023

Both of these crates serialise decimals as strings, not as plain numbers.

Half-fixes #123 - there's not yet a good way to handle different schemas for serialization vs deserialization, so this PR just makes the schemas match how these types are serialized (numeric strings).

Both of these crates serialise decimals as strings, not as plain numbers
@GREsau GREsau merged commit db1dd47 into master Sep 17, 2023
8 checks passed
@GREsau GREsau deleted the decimal-as-string branch September 17, 2023 19:31
SohumB added a commit to SohumB/schemars that referenced this pull request Jan 1, 2024
This reverts commit db1dd47.

# Conflicts:
#	schemars/Cargo.toml
#	schemars/tests/decimal.rs
#	schemars/tests/expected/bigdecimal03.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema for BigDecimal is not correct
1 participant