simplify the code generated for unit, externally tagged and internally tagged enums #266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial solution for #246
Schema::Object
with a helper methodTaking the enum from https://github.com/adamchalmers/rust-problems/blob/achalmers/schemars-llvm-lines/src/lib.rs and running
cargo rustc -- -Z unpretty=mir | wc -l
it goes from 165725 lines of MIR to 4871 (removing the serde derives from the linked code)The per-variant generate code goes from:
to:
I still have a crate that takes forever to generate the schema for so there are still plenty of room for improvement.