Add propertyNames field in maps
#361
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
propertyNamesfield to map schemas and a transformer to remove the field. This is useful in OpenAPI 3.0 which doesn't support it.This is a breaking change since the key type of maps must now also implement JsonSchema.
Unfortunately, I've not been able to get the
FlattenValuetest working - it's probably because the additional field gets deserialized in only some cases. For this reason, this PR is a draft. I'll try to tinker with it later, but if I could get some advice on resolving this problem, I'd be happy to fix the test.Fixes #235.