Pipenv #657
Pipenv #657
Conversation
This takes forever... see pypa/pipenv#4430
|
Unanswered questions:
|
ckan/requirements.txt
Outdated
| alembic==1.0.0 | ||
| async-timeout==4.0.2 | ||
| Babel==2.9.1 | ||
| Beaker==1.11.0 | ||
| argparse==1.4.0 |
There was a problem hiding this comment.
Ideally this whole file is removed...
Also, add metrics dashboard back in
ckan/Dockerfile
Outdated
| @@ -31,11 +24,18 @@ ENV PIP_SRC=${SRC_DIR} | |||
| ENV CKAN_STORAGE_PATH=/var/lib/ckan | |||
| RUN mkdir -p $CKAN_STORAGE_PATH $APP_DIR | |||
|
|
|||
| ADD Pipfile Pipfile.lock ${APP_DIR}/ | |||
| ENV PIPENV_PIPFILE=/${APP_DIR}/Pipfile | |||
| RUN pip3 install --upgrade pipenv && pipenv install --ignore-pipfile | |||
There was a problem hiding this comment.
Why are we ignoring pipfile here? I think we want to use that...
There was a problem hiding this comment.
We're ignoring pipfile in favor of pipfile.lock which is the hard set of requirements.
ckan/freeze-requirements.sh
Outdated
| set -o errexit | ||
| set -o pipefail | ||
|
|
||
| venv=$(mktemp -d) | ||
| pip3 install pipenv |
There was a problem hiding this comment.
I don't think we want this file anymore, but we should use the standard pipenv pinning and upgrading process
ckan/setup/ckan_setup.sh
Outdated
| done | ||
|
|
||
| echo "Enabling debug mode" |
There was a problem hiding this comment.
See lines 19-26 in this file, I think we'll have to do something a little different...
| @@ -10,7 +10,7 @@ DIR="$(dirname "${BASH_SOURCE[0]}")" | |||
| # Threads RAM requirement unknown at this time | |||
| # exec newrelic-admin run-program gunicorn -c "$DIR/gunicorn.conf.py" --worker-class gevent --paste $CKAN_INI "$@" | |||
| if [[ "$CKAN_SITE_URL" = "http://ckan:5000" ]]; then | |||
| exec newrelic-admin run-program gunicorn "wsgi:application" --config "$DIR/gunicorn.conf.py" -b "0.0.0.0:$PORT" --chdir $DIR --timeout 120 --workers 2 | |||
| exec pipenv run newrelic-admin run-program gunicorn "wsgi:application" --config "$DIR/gunicorn.conf.py" -b "0.0.0.0:$PORT" --chdir $DIR --timeout 120 --workers 2 | |||
| else | |||
| exec newrelic-admin run-program gunicorn "wsgi:application" --config "$DIR/gunicorn.conf.py" -b "0.0.0.0:$PORT" --chdir $DIR --timeout 120 --worker-class gevent --workers 4 --threads 4 --forwarded-allow-ips='*' | |||
There was a problem hiding this comment.
Equivalent pipenv run needed here possibly; or maybe not? would require cloud.gov testing.
There was a problem hiding this comment.
Okay, I'll look into this.
I still have to test if pipenv can be manipulated manually instead of from inside of docker
This switches gears a bit and keepsthe optimal pip performance for local development and build and testing. And uses the management optimal pipenv for cloud.gov 'vendoring' which just ensures that compatible versions are referenced in the cloud.gov environment
|
If this is ever re-visited for future work, there is still a lot of work to do with ensuring all of the dependencies are cloud.gov-compatible. There was no concrete path forward from the current state. |
Related to
References: