fixed issue #130, so people can select from browse by agency multiple time #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tiple times and browse projects will only filter by that agency selected each time
DanielJDufour
changed the title
|
Don't review this yet. Just discovered a bug when I select |
|
Ready for review now |
DanielJDufour
changed the title
ftonato
reviewed
Dec 26, 2018
| @@ -25,21 +25,21 @@ const mapDispatchToProps = dispatch => { | |||
| const value = normalize(event.target.value) | |||
| if (value !== 'browse by agency') { | |||
| let url | |||
There was a problem hiding this comment.
let url = `/browse-projects?agencies=${value}&page=1&size=10&sort=data_quality`
ftonato
reviewed
Dec 26, 2018
| size: 10, | ||
| sort: 'data_quality', | ||
| filters: [] | ||
| } | ||
| if (value === 'all') { | ||
| url = '/browse-projects?page=1&size=10&sort=data_quality' |
There was a problem hiding this comment.
url = url.split(`agencies=${value}&`).join('')
|
Hello @DanielJDufour, Your changes that enough, but I suggest simple updates (you can see above). |
saracope
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A similar PR may already be submitted!
Please search among the Pull request before creating one.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:
For more information, see the
CONTRIBUTINGguide.Summary
This PR fixes/implements the following bugs/features
Explain the motivation for making this change. What existing problem does the pull request solve?
Issue #130
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Manually tested and also added to pre-deploy testing checklist
Code formatting
Closing issues
Fixes #130