Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility fixes #212

Merged
merged 11 commits into from
Jun 1, 2019
Merged

Accessibility fixes #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
11b4e74
update search
saracope May 24, 2019
9b0695b
updates for accessibility
saracope May 24, 2019
9045745
accessibility fixes
saracope May 24, 2019
261e626
fix merge conflict
saracope May 24, 2019
79d3522
Add mobile styling for scroll-indicator
saracope May 29, 2019
96cf753
Merge branch 'master' into sc_pa11y-fixes
saracope May 31, 2019
4a5efe3
update scroll indicator
saracope May 31, 2019
e21e738
Update pa11y config urls
saracope Jun 1, 2019
03a0c18
add pa11y to test script
saracope Jun 1, 2019
a8758ac
revert code cleanup changes
saracope Jun 1, 2019
bb9c501
update to fix failing test
saracope Jun 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .pa11yci
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,21 @@
}
},
"urls": [
"http://localhost:8080/projects/nsa_1_atomicwatch",
"http://localhost:8080/projects/gsa_18f_1_10x_product_market_research",
"http://localhost:8080/projects/dod_nci_agency_1_anet"
"http://localhost:8080/projects/nsa_1_atomicwatch",
"http://localhost:8080/projects/dod_nci_agency_1_anet",
"http://localhost:8080/browse-projects",
"http://localhost:8080/about/overview/introduction",
"http://localhost:8080/about/overview/tracking-progress",
"http://localhost:8080/open-tasks",
"http://localhost:8080/about/compliance/dashboard",
"http://localhost:8080/about/compliance/procurement",
"http://localhost:8080/about/compliance/inventory-code",
"http://localhost:8080/about/open-source/introduction",
"http://localhost:8080/about/open-source/resources",
"http://localhost:8080/about/open-source/measuring-code",
"http://localhost:8080/about/open-source/licensing",
"http://localhost:8080/policy-guide/introduction",
"http://localhost:8080/policy-guide/objectives"
]
}
2 changes: 1 addition & 1 deletion 404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<script>
var location = window.location;
Expand Down
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>

<script>
Expand Down
82 changes: 22 additions & 60 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
"update-data": "node update-data.js",
"update-fonts": "cp -r ./node_modules/@code.gov/code-gov-style/assets/font/* ./assets/fonts/.",
"snyk": "snyk test",
"test": "jest --coverage",
"test": "jest --coverage && npm run test-pa11y",
"test:ci": "jest --coverage --ci",
"test-pa11y": "./node_modules/.bin/pa11y-ci --config .pa11yci --sitemap https://raw.githubusercontent.com/GSA/code-gov-site-map-generator/master/sitemap.xml --sitemap-find https://code.gov --sitemap-replace http://localhost:8080 --sitemap-exclude /projects",
"test-pa11y": "./node_modules/.bin/pa11y-ci --config .pa11yci",
"test-watch": "jest --watch"
},
"husky": {
Expand Down
2 changes: 2 additions & 0 deletions src/components/autocomplete/__snapshots__/autocomplete.component.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ exports[`components - Autocomplete should render correctly 1`] = `
to="/to-1"
>
<i
aria-label="search"
className="icon icon-search"
/>
<span>
Expand All @@ -27,6 +28,7 @@ exports[`components - Autocomplete should render correctly 1`] = `
to="/to-2"
>
<i
aria-label="search"
className="icon icon-search"
/>
<span>
Expand Down
2 changes: 1 addition & 1 deletion src/components/autocomplete/autocomplete.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default function Autocomplete({ onClick, options }) {
return (
<li key={to}>
<CustomLink onClick={() => onClick & onClick(option)} to={to}>
<i className="icon icon-search"/>
<i aria-label="search" className="icon icon-search"/>
<span>{text}</span>
</CustomLink>
</li>
Expand Down
1 change: 0 additions & 1 deletion src/components/custom-link/custom-link.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import React, { Component } from 'react'
import { Link } from 'react-router-dom'

export default class CustomLinkComponent extends Component {

onClick(event) {
if (this.props.onClick) {
this.props.onClick(event)
Expand Down
Loading