Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home redesign #240

Merged
merged 44 commits into from
Jun 20, 2019
Merged

Home redesign #240

merged 44 commits into from
Jun 20, 2019

Conversation

saracope
Copy link
Contributor

Summary

This PR fixes/implements the following bugs/features

  • Redesign of the style and layout for the home page
  • Redesign the sub pages to remove the flag banner

BEFORE

screencapture-code-gov-2019-06-19-22_51_36
.
.
screencapture-code-gov-browse-projects-2019-06-19-22_52_16
.
.
.
AFTER
screencapture-localhost-8080-2019-06-19-22_45_20
.
.
screencapture-localhost-8080-browse-projects-2019-06-19-22_53_36

@saracope saracope merged commit 908d7be into master Jun 20, 2019
@saracope saracope deleted the smashingboxes-sc_redesign branch June 20, 2019 11:32
@ftonato
Copy link
Contributor

ftonato commented Jun 20, 2019

Hello,
I was reading the code, just the footer code and has many problems that I have figured out...

  • Styles using "position absolute" when a simple "display: block" can fix it;
  • Styles with magic rules like translateY(-50%) to position elements;
  • Styles that rewrite default props like text-align: left; and others...

Can I send a pull-request re-writing all footer using Flexbox?

@saracope saracope mentioned this pull request Jun 20, 2019
@ftonato ftonato mentioned this pull request Jun 22, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants