Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack style loaders #278

Merged
merged 4 commits into from
Aug 5, 2019
Merged

Update webpack style loaders #278

merged 4 commits into from
Aug 5, 2019

Conversation

saracope
Copy link
Contributor

@saracope saracope commented Aug 1, 2019

Summary

This PR fixes/implements the following bugs/features

  • Add postcss loader for autoprefixer (browser prefixing) and css-mqpacker (media query packing)
  • Comments out FaviconsWebpackPlugin as it was causing errors. Need to find a replacement for this, see Remove favicons-webpack-plugin #178.
  • Fix sourcemaps to show in dev, uses eval-source-map
  • Add browserslist config in package.json for postcss processing
  • Increased pa11y timeout to 30000ms to fix circleci timeout issue

Explain the motivation for making this change. What existing problem does the pull request solve?

This is in prep for full move to USWDS 2.x which needs vendor prefixing and media query packing.

@saracope saracope force-pushed the sc_update-webpack branch from 7fdaf8d to a7ff997 Compare August 1, 2019 23:30
@saracope
Copy link
Contributor Author

saracope commented Aug 1, 2019

Pa11y is running locally:

* sc_update-webpack
FCOH2J-K19GHV2F:code-gov-front-end saradcope$ npm run test-pa11y

> @code.gov/code-gov-front-end@1.0.1 test-pa11y /Users/saradcope/Documents/Sites/code-gov-repos/code-gov-front-end
> pa11y-ci --config .pa11yci

Running Pa11y on 14 URLs:
 > http://localhost:8080/projects/nsa_1_atomicwatch - 0 errors
 > http://localhost:8080/projects/gsa_18f_1_10x_product_market_research - 0 errors
 > http://localhost:8080/projects/dod_nci_agency_1_anet - 0 errors
 > http://localhost:8080/browse-projects - 0 errors
 > http://localhost:8080/about/overview/tracking-progress - 0 errors
 > http://localhost:8080/about/overview/introduction - 0 errors
 > http://localhost:8080/open-tasks - 0 errors
 > http://localhost:8080/about/compliance/dashboard - 0 errors
 > http://localhost:8080/about/compliance/procurement - 0 errors
 > http://localhost:8080/about/compliance/inventory-code - 0 errors
 > http://localhost:8080/about/open-source/introduction - 0 errors
 > http://localhost:8080/about/open-source/resources - 0 errors
 > http://localhost:8080/about/open-source/measuring-code - 0 errors
 > http://localhost:8080/about/open-source/licensing - 0 errors

✔ 14/14 URLs passed```

@saracope
Copy link
Contributor Author

saracope commented Aug 2, 2019

Updated the pa11y timeout to resolve circleci issue.

@saracope saracope merged commit 283ce75 into master Aug 5, 2019
@saracope saracope deleted the sc_update-webpack branch August 5, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant