Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .nvmrc to define node version #375

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Use .nvmrc to define node version #375

merged 1 commit into from
Apr 21, 2020

Conversation

hursey013
Copy link
Contributor

At the moment, the application does not run properly when using later versions of Node.js. Adding a .nvmrc file provides some self-documentation as well as support for command line tools that can automatically switch to the correct version of Node.js during development.

Copy link
Contributor

@jcastle-zz jcastle-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hursey013, our documentation says to run Node 10.15.1. I am running 10.17.0 and seems okay. Does 10.19.0 work too? Should we standardize on one and update the documentation?

@jcastle-zz jcastle-zz merged commit cdd30c7 into master Apr 21, 2020
@jcastle-zz jcastle-zz deleted the bh-nvmrc branch April 21, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants