Enable Federalist previews #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcastle-zz
added
[area] platform
seanstar12
approved these changes
Apr 28, 2020
|
After testing, I believe the infinite redirect is an acceptable risk for the 404 page. I was unable to replicate locally, and I think the benefits of this branch outweigh the redirect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the path of various assets and routing components to accommodate the unique url structure of Federalist preview branches. This will allow changes to be view on the branch specific URLs like https://federalist-88023b0b-4406-431f-932d-5fd82c70c515.app.cloud.gov/preview/gsa/code-gov-front-end/bh-public-path/ without having to merge to
stagingto view.This appears to be working well locally and on the Federalist branches, but I would like to see how it works on the staging branch before merging it to production.
There is also one caveat that will either need to be accepted, or worked around in a future PR. There is logic hardcoded in the 404.html and index.html pages that strips the path/query string of the URL out and redirects to the base URL - this is the expected behavior on the production site, but on a Federalist preview URL it will cause an infinite reloading loop.