Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added title field to the Harvest Error Record Report page with block view #131

Merged
merged 21 commits into from
Feb 10, 2025
Merged

Added title field to the Harvest Error Record Report page with block view #131

merged 21 commits into from
Feb 10, 2025

Conversation

Jin-Sun-tts
Copy link
Contributor

Pull Request

Related to GSA/data.gov#4980

About

  • Retrieve the title and identifier for each record with an error and display them in a table.
  • Added a block view for each error record, along with a button to toggle between the block view and table view.

@Jin-Sun-tts Jin-Sun-tts requested a review from a team February 3, 2025 14:15
@rshewitt
Copy link
Contributor

rshewitt commented Feb 3, 2025

pagination is buggy with switch from table to block view. see video.

Screen.Recording.2025-02-03.at.11.28.37.AM.mov

@rshewitt
Copy link
Contributor

rshewitt commented Feb 3, 2025

pytest check appears broken. green check with failing tests.

@Jin-Sun-tts
Copy link
Contributor Author

pytest errors were fixed

pytest check appears broken. green check with failing tests.

@Jin-Sun-tts Jin-Sun-tts changed the title Added title field to the Harvest Error Record Report page with two view options. Added title field to the Harvest Error Record Report page with block view Feb 6, 2025
btylerburton
btylerburton reviewed Feb 10, 2025
View reviewed changes
app/static/_scss/view-styles.css Outdated Show resolved Hide resolved
app/static/_scss/view-styles.css Outdated Show resolved Hide resolved
app/templates/base.html Outdated Show resolved Hide resolved
database/interface.py Show resolved Hide resolved
@Jin-Sun-tts Jin-Sun-tts merged commit 2b27e91 into main Feb 10, 2025
4 checks passed
@Jin-Sun-tts Jin-Sun-tts deleted the add-title-to-report-page branch February 10, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btylerburton btylerburton btylerburton approved these changes

@rshewitt rshewitt Awaiting requested review from rshewitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jin-Sun-tts @rshewitt @btylerburton