Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Ruby code for Asset Helper Plugin #1229

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

claytonjbarnette
Copy link
Member

Ruby Plugin Code Updated :

Preview

  • File: /plugins/asset-helper.rb
  • Added code to copy over individual files from the node_modules/@uswds/uswds/dist/css/ folder of the @uswds npm package.
  • The asset-helper.rb already copies over entire directories, but did not copy individual files from the @uswds/uswds/dist/css/ folder.

Note: This copying of file happens automatically with every build of the site, simply making this manual process automatic to aid in updating the @uswds package when a new version is released.

  • The script copies the following files:
    • node_modules/@uswds/uswds/dist/css/uswds.css
    • node_modules/@uswds/uswds/dist/css/uswds.min.css
    • node_modules/@uswds/uswds/dist/css/uswds.min.css.map
  • to the /assets/css/ folder on the site.
  • Now when a new version of the USWDS is released, the manual process of copying .css, min.css, and .min.css.map files is now automatic. happening once the site builds.
  • This was a manual process, the original helper added in the cloud.gov Ruby upgrade did not copy these files.
  • Comments added for clarity of update and function use.

Possible Noticeable Improvements:

  • Better component functionality.
  • Cleaner fonts and icon.
  • Small formatting adjustments may be more visible after a USWDS update.
  • a tighter integration of USWDS across the entire site.

No real visual changes to point to, but this should help the site function and build better relative to USWDS.

@SuGhadiali
@TheInfinityBeyonder

📅 12/09/2024

@JBPayne007 JBPayne007 merged commit 408e191 into staging Dec 10, 2024
4 checks passed
@JBPayne007 JBPayne007 deleted the 1209-ruby-asset-helper-update branch December 10, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants