Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔀 :: [#334] GSM 인증제 Form UI 추가 #338

Merged
merged 7 commits into from
Jul 6, 2024

Conversation

baekteun
Copy link
Member

💡 배경 및 개요

Resolves: #334

📃 작업내용

아래 구조체의 정보를 입력하면 UI를 만들어주는 UI를 작성

import Foundation

// swiftlint: disable nesting
struct GSMAuthenticationFormUIModel {
    let areas: [Area]

    struct Area {
        let title: String
        let files: [File]
        let sections: [Section]

        struct File {
            let name: String
            let url: String
        }

        struct Section {
            let title: String
            let description: String
            let currentFieldCount: Int
            let fields: [Field]

            struct Field {
                let key: String
                let type: FieldType
                let placeholder: String?

                enum FieldType {
                    case text(value: String?)
                    case number(value: Int?)
                    case boolean(isSelcted: Bool?)
                    case file(fileName: String?)
                    case select(selectedValue: String?, values: [String])
                }
            }
        }
    }
}
// swiftlint: enable nesting

🙋‍♂️ 리뷰노트

  • 뭔가 key값이나 액션 놓친게 있었는지 체크 필요해요
    • 놓친게 아니더라도 필요한 것들 추가도 하면 좋구요

✅ PR 체크리스트

템플릿 체크리스트 말고도 추가적으로 필요한 체크리스트는 추가해주세요!

  • 이 작업으로 인해 변경이 필요한 문서가 변경되었나요? (e.g. .env, 노션, README)
  • 이 작업을 하고나서 공유해야할 팀원들에게 공유되었나요? (e.g. "API 개발 완료됐어요", "환경값 추가되었어요")
  • 작업한 코드가 정상적으로 동작하나요?
  • Merge 대상 브랜치가 올바른가요?
  • PR과 관련 없는 작업이 있지는 않나요?

@baekteun baekteun added 0️⃣ Priority: Critical 우선순위 - 긴급!!!!! ✨ Feature 신규 기능 labels May 28, 2024
@baekteun baekteun self-assigned this May 28, 2024
@baekteun baekteun requested a review from kimsh153 May 30, 2024 06:05
@baekteun baekteun force-pushed the 334-authentication-form-ui-building branch from 40015e8 to 79491e2 Compare May 31, 2024 13:54
Copy link

@leehyeonbin leehyeonbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 description 부분이 아직 사용되고 있지 않는 듯 보이는데, 한 번 확인해주실 수 있나요?

@baekteun baekteun changed the base branch from master to 334-authentication-form-ui June 1, 2024 13:07
Base automatically changed from 334-authentication-form-ui to master June 8, 2024 21:49
@baekteun baekteun merged commit 68060e2 into master Jul 6, 2024
1 check passed
@baekteun baekteun deleted the 334-authentication-form-ui-building branch July 6, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0️⃣ Priority: Critical 우선순위 - 긴급!!!!! ✨ Feature 신규 기능
Projects
None yet
Development

Successfully merging this pull request may close these issues.

인증제 Form UI 추가
3 participants