Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill Disassembler 🔪 #1855

Merged
merged 4 commits into from
Apr 8, 2023
Merged

Kill Disassembler 🔪 #1855

merged 4 commits into from
Apr 8, 2023

Conversation

Connor-Colenso
Copy link
Contributor

@Connor-Colenso Connor-Colenso commented Apr 8, 2023

Requires 3 other PRs in other repos to resolve loss off public stuff.

Arc furnaces at EV+ compensated to 9 slots to allow recycling to occur still with less loss at Dreams request.

Loads in full pack but other PRs are essential for this.

@Dream-Master
Copy link
Member

i would suggest to let the machines still in with no function and no crafting recipe to stay bachwards compatible

@boubou19
Copy link
Member

boubou19 commented Apr 8, 2023

backwards compatible means we can still use the machine. The idea is to remove it totally, as we plan to replace it by increasing Arc Furnace's outputs. No need to keep dead code when we remove a content permanently. One of the reasons GT and their addons is a mess code wise is that we decided to keep too many dead/useless code. Time to clean GT

@Dream-Master
Copy link
Member

backwards compatible means we can still use the machine. The idea is to remove it totally, as we plan to replace it by increasing Arc Furnace's outputs. No need to keep dead code when we remove a content permanently. One of the reasons GT and their addons is a mess code wise is that we decided to keep too many dead/useless code. Time to clean GT

No i mean the block id is still there and the machine are displayed but it wont work for any recipe

@Dream-Master Dream-Master merged commit d550cd0 into master Apr 8, 2023
@Dream-Master Dream-Master deleted the kill_disassembler branch April 8, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants