Fix crash when configuring ender tank covers #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client was calling DimensionManager.getWorld on the client when it shouldn't have been. The fix was to move the private/public toggling code into the cover update method, so that it gets called on the server instead of the client. This is slightly less efficient, but the code is trivial so it doesn't matter. This change doesn't have any side effects because the relevant code is only used in the ender tank cover.
serenibyss
approved these changes
Nov 27, 2024
serenibyss
added
bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client was calling DimensionManager.getWorld on the client when it shouldn't have been.
The fix was to move the private/public toggling code into the cover update method, so that it gets called on the server instead of the client. This is slightly less efficient, but the code is trivial so it doesn't matter.
This change doesn't have any side effects because the relevant code is only used in the ender tank cover.
This was tested by starting a server and moving fluids between two super tanks. I repeatedly toggled the public/private buttons without closing the cover UI to make sure the change actually took effect.
Fixes: GTNewHorizons/GT-New-Horizons-Modpack#17863 and GTNewHorizons/GT-New-Horizons-Modpack#17991