Ability to add version specific properties #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eigenraven
requested changes
Nov 26, 2024
| @@ -811,6 +965,12 @@ public void initFromProperties(Map<?, ?> props, BiConsumer<String, Object> onMis | |||
| if (prop == null) { | |||
| continue; | |||
| } | |||
| final String mcVersion = prop.mcVersion(); | |||
| if (!mcVersion.isEmpty()) { | |||
| if (!GTNHGradlePlugin.MinecraftVersion.isAcceptableMinecraftVersion(mcVersion)) { | |||
There was a problem hiding this comment.
This class is loaded in an isolated classloader during the update process, so it shouldn't use the GTNHGradlePlugin class at all or it will crash the script updater. Moving MinecraftVersion to not be an inner class and making sure it doesn't have any gradle or other library dependencies would be required to use it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to defined version specific properties.
Properties can now be defined as 1.7.10 or 1.12.2 only, with the default of
""allowing all versions.Properties that do not match with the version will not be parsed, and will not be added into properties.gradle on automatic update.