Fix speedupBOPFogHandling incompatibility
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using GasStation 0.3.4,
speedupBOPFogHandlingproduces a very similar crash to #72. This happened because GasStation didn't handle inner mixin classes correctly. (FalsePattern/GasStation#3)This gave me the idea to refactor the mixin to not use an inner class, and instead move its implementation into a helper class. This fixes the crash, and the crash with BetterFPS as well.
I verified that the mixin still works.
EntityRenderer#setupFogtakes up 4.7% of CPU time when it's disabled, which goes down to 0.1% when it's enabled.